-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM ID annotations for Compute VMSS/VMs #19597
Conversation
Hi, @matthchr Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
2022-03-01 | 2022-03-01(3e6f969) | 2022-03-01(main) |
compute.json | 2020-12-01(3e6f969) | 2020-12-01(main) |
compute.json | 2021-03-01(3e6f969) | 2021-03-01(main) |
compute.json | 2021-04-01(3e6f969) | 2021-04-01(main) |
compute.json | 2021-07-01(3e6f969) | 2021-07-01(main) |
compute.json | 2021-11-01(3e6f969) | 2021-11-01(main) |
computeRPCommon.json | 2022-03-01(3e6f969) | 2022-03-01(main) |
Rule | Message |
---|---|
1023 - TypeFormatChanged |
The new version has a different format than the previous one. New: Microsoft.Compute/stable/2022-03-01/common.json#L146:9 Old: Microsoft.Compute/stable/2022-03-01/common.json#L146:9 |
Only 15 items are listed, please refer to log for more details.
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 12 Errors, 0 Warnings failed [Detail]
The following errors/warnings are introduced by current PR:
Rule | Message |
---|---|
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-11-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-08-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-10-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-07-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2021-06-01-preview", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Duplicated model name with non-identical definitions" |
AutoRest exception |
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Duplicated model name with non-identical definitions" |
The following errors/warnings exist before current PR submission:
Only 15 items are listed, please refer to log for more details.
Rule | Message |
---|---|
D5001 - XmsExamplesRequired |
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Compute/stable/2020-12-01/compute.json#L36 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L49 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L100 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L151 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L188 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L225 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L257 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L297 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L339 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L390 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L447 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L489 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L535 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L565 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2020-12-01/compute.json#L605 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-04-04 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
ModelValidation: 357 Errors, 0 Warnings failed [Detail]
Only 15 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 24 Warnings warning [Detail]
- The following tags are being changed in this PR
- compute/resource-manager/readme.md#package-2022-04-04
- compute/resource-manager/readme.md#package-2022-03-02
- compute/resource-manager/readme.md#package-2022-01-03
- compute/resource-manager/readme.md#package-2022-03-01
- compute/resource-manager/readme.md#package-2022-03-01-only
- compute/resource-manager/readme.md#package-2021-12-01
- compute/resource-manager/readme.md#package-2021-11-01
- compute/resource-manager/readme.md#package-2021-11-01-only
- compute/resource-manager/readme.md#package-2021-08-01
- compute/resource-manager/readme.md#package-2021-10-01
- compute/resource-manager/readme.md#package-2021-07-01
- compute/resource-manager/readme.md#package-2021-07-01-only
- compute/resource-manager/readme.md#package-2021-06-01-preview
- compute/resource-manager/readme.md#package-2021-04-01
- compute/resource-manager/readme.md#package-2021-04-01-only
- compute/resource-manager/readme.md#package-2021-03-01
- compute/resource-manager/readme.md#package-2021-03-01-only
- compute/resource-manager/readme.md#package-2020-12-01
- compute/resource-manager/readme.md#package-2020-12-01-only
Only 15 items are listed, please refer to log for more details.
Rule | Message |
---|---|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-12-01", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-12-01", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-12-01", "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]" |
The following errors/warnings exist before current PR submission:
Only 15 items are listed, please refer to log for more details.
Rule | Message |
---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Process() cancelled due to failure " |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"!Error: Plugin prechecker reported failure." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Process() cancelled due to failure " |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"!Error: Plugin prechecker reported failure." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Process() cancelled due to failure " |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"!Error: Plugin prechecker reported failure." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Process() cancelled due to failure " |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"!Error: Plugin prechecker reported failure." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-12-01", "details":"Process() cancelled due to failure " |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-12-01", "details":"!Error: Plugin prechecker reported failure." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-12-01", "details":"Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Hi @matthchr, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @matthchr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi, @matthchr. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @matthchr. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
Uses the new arm-id format to describe fields which are references to other ARM resources.
This was split off from #18318
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.