Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM ID annotations for Compute VMSS/VMs #19597

Closed
wants to merge 1 commit into from

Conversation

matthchr
Copy link
Member

Uses the new arm-id format to describe fields which are references to other ARM resources.

This was split off from #18318

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @matthchr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 24, 2022

    Swagger Validation Report

    ️❌BreakingChange: 78 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    2022-03-01 2022-03-01(3e6f969) 2022-03-01(main)
    compute.json 2020-12-01(3e6f969) 2020-12-01(main)
    compute.json 2021-03-01(3e6f969) 2021-03-01(main)
    compute.json 2021-04-01(3e6f969) 2021-04-01(main)
    compute.json 2021-07-01(3e6f969) 2021-07-01(main)
    compute.json 2021-11-01(3e6f969) 2021-11-01(main)
    computeRPCommon.json 2022-03-01(3e6f969) 2022-03-01(main)
    Rule Message
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2022-03-01/common.json#L146:9
    Old: Microsoft.Compute/stable/2022-03-01/common.json#L146:9

    Only 15 items are listed, please refer to log for more details.

    Rule Message
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L10625:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L10625:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L12344:9
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L12343:9
    1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.Compute/stable/2021-03-01/compute.json#L13593:9
    Old: Microsoft.Compute/stable/2021-03-01/compute.json#L13592:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 12 Errors, 0 Warnings failed [Detail] The following errors/warnings are introduced by current PR:
    Rule Message
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-04-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-03-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-11-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-08-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-10-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-07-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Duplicated model name with non-identical definitions"
    AutoRest exception "location":"specification/compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Duplicated model name with non-identical definitions"


    The following errors/warnings exist before current PR submission:

    Only 15 items are listed, please refer to log for more details.

    Rule Message
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L36
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L49
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L100
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L151
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L188
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L225
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L257
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L297
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L339
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L390
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L447
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L489
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L535
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L565
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L605
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-04-04
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 357 Errors, 0 Warnings failed [Detail]

    Only 15 items are listed, please refer to log for more details.

    Rule Message
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Operations_List.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L38:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_Update.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L114:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_Delete.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L160:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_Get.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L197:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_List.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L276:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in AvailabilitySets_ListAvailableSizes.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L311:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_Update.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L681:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_Delete.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L727:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_ListByResourceGroup.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L822:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHostGroups_ListBySubscription.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L857:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHosts_Update.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L950:16
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHosts_Delete.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L1004:17
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in DedicatedHosts_ListByHostGroup.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L1117:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in SshPublicKeys_ListBySubscription.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L1159:14
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in SshPublicKeys_ListByResourceGroup.
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L1187:14
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 24 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 15 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-12-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > SharingStatus > properties > aggregatedState)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-12-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > RegionalSharingStatus > properties > state)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-12-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OSDiskImageEncryption > properties > securityProfile)\n keys: [ \u001b[32m'type'\u001b[39m ]"


    The following errors/warnings exist before current PR submission:

    Only 15 items are listed, please refer to log for more details.

    Rule Message
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Process() cancelled due to failure "
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"!Error: Plugin prechecker reported failure."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Autorest completed with an error. If you think the error message is unclear,
    or is a bug,
    please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Process() cancelled due to failure "
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"!Error: Plugin prechecker reported failure."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Autorest completed with an error. If you think the error message is unclear,
    or is a bug,
    please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Process() cancelled due to failure "
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"!Error: Plugin prechecker reported failure."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Autorest completed with an error. If you think the error message is unclear,
    or is a bug,
    please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Process() cancelled due to failure "
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"!Error: Plugin prechecker reported failure."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Autorest completed with an error. If you think the error message is unclear,
    or is a bug,
    please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-12-01",
    "details":"Process() cancelled due to failure "
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-12-01",
    "details":"!Error: Plugin prechecker reported failure."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2021-12-01",
    "details":"Autorest completed with an error. If you think the error message is unclear,
    or is a bug,
    please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing."
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 24, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-go failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @matthchr, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @matthchr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @ghost
    Copy link

    ghost commented Aug 7, 2022

    Hi, @matthchr. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Aug 7, 2022
    @ghost ghost closed this Aug 22, 2022
    @ghost
    Copy link

    ghost commented Aug 22, 2022

    Hi, @matthchr. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    This pull request was closed.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants